Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests for msvc #264

Merged
merged 11 commits into from
Mar 21, 2022
Merged

Fix tests for msvc #264

merged 11 commits into from
Mar 21, 2022

Conversation

chaeyeunpark
Copy link
Contributor

Currently, MSVC does not compile the test executable. This PR enables MSVC to compile the tests and fix some errors/warnings from MSVC.

Also closes #263

@github-actions
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@codecov
Copy link

codecov bot commented Mar 21, 2022

Codecov Report

Merging #264 (a27c8a4) into master (368b2bb) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #264   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          379       379           
=========================================
  Hits           379       379           
Impacted Files Coverage Δ
pennylane_lightning/_version.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 368b2bb...a27c8a4. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 21, 2022

Test Report (C++) on Ubuntu

           1 files  ±0             1 suites  ±0   0s ⏱️ ±0s
       660 tests ±0         660 ✔️ ±0  0 💤 ±0  0 ±0 
228 174 runs  ±0  228 174 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit a27c8a4. ± Comparison against base commit 368b2bb.

♻️ This comment has been updated with latest results.

@mlxd
Copy link
Member

mlxd commented Mar 21, 2022

Thanks @chaeyeunpark
Do the changes require an update to the CI to build and run the test-suite there also?

@chaeyeunpark
Copy link
Contributor Author

chaeyeunpark commented Mar 21, 2022

Do the changes require an update to the CI to build and run the test-suite there also?

Hi @mlxd, not yet, but I am anyway planning to add tests on Windows with MSVC in CI for C++ code coverage (in a following PR).

@mlxd
Copy link
Member

mlxd commented Mar 21, 2022

Do the changes require an update to the CI to build and run the test-suite there also?

Hi @mlxd, not yet, but I am anyway planning to add tests on Windows with MSVC in CI for C++ code coverage (in a following PR).

Great, thanks @chaeyeunpark
I'll approve when all tests are green.

@chaeyeunpark chaeyeunpark requested a review from mlxd March 21, 2022 16:29
@chaeyeunpark chaeyeunpark requested a review from maliasadi March 21, 2022 19:36
Copy link
Member

@maliasadi maliasadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat update @chaeyeunpark. Happy to approve.

@chaeyeunpark chaeyeunpark merged commit 5e01cf9 into master Mar 21, 2022
@chaeyeunpark chaeyeunpark deleted the fix_tests_for_msvc branch March 21, 2022 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjoint jacobian throws std::range_error
3 participants