-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tests for msvc #264
Fix tests for msvc #264
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov Report
@@ Coverage Diff @@
## master #264 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 379 379
=========================================
Hits 379 379
Continue to review full report at Codecov.
|
Thanks @chaeyeunpark |
Hi @mlxd, not yet, but I am anyway planning to add tests on Windows with MSVC in CI for C++ code coverage (in a following PR). |
Great, thanks @chaeyeunpark |
…-lightning into fix_tests_for_msvc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat update @chaeyeunpark. Happy to approve.
Currently, MSVC does not compile the test executable. This PR enables MSVC to compile the tests and fix some errors/warnings from MSVC.
Also closes #263