Add clang-tidy checks, runtime and compile time information, a C++ kernel test #253
Conversation
|
Hello. You may have forgotten to update the changelog!
|
…ennylane-lightning into pre_better_kernel_dispatch
Codecov Report
@@ Coverage Diff @@
## master #253 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 379 379
=========================================
Hits 379 379
Continue to review full report at Codecov.
|
| option_spec = {'name': directives.unchanged, | ||
| 'description': directives.unchanged, | ||
| 'link': directives.unchanged} | ||
| option_spec = { |
There was a problem hiding this comment.
This file is just formatted using black
| @@ -8,19 +8,20 @@ | |||
| import warnings | |||
There was a problem hiding this comment.
This file is also just formatted with black
chaeyeunpark
requested review from
mlxd and
maliasadi
and removed request for
mlxd
There was a problem hiding this comment.
Nice work @chaeyeunpark! Looking forward to review the followup PRs 🚀
pennylane_lightning/src/tests/Test_GateImplementations_CompareKernels.cpp
Show resolved
Hide resolved
pennylane_lightning/src/tests/Test_GateImplementations_CompareKernels.cpp
Show resolved
Hide resolved
Co-authored-by: Ali Asadi <ali@xanadu.ai>
Co-authored-by: Ali Asadi <ali@xanadu.ai>
There was a problem hiding this comment.
Nice work @chaeyeunpark
I have a few comments and suggestions.
Co-authored-by: Ali Asadi <ali@xanadu.ai>
…ennylane-lightning into pre_better_kernel_dispatch
There was a problem hiding this comment.
This is fantasic @chaeyeunpark
I have a few questions:
- Do we want this class to be public facing https://pennylane-lightning--253.org.readthedocs.build/en/253/api/structPennylane_1_1registerBeforeMain.html#exhale-struct-structPennylane-1-1registerBeforeMain as it seems to be registered in the docs several times with diff template params (see here)
- As above but with this
- Do the gate kernel definition guidelines still work in the same way as listed on the site?
- Should the PR be renamed to something more representative of the changes?
| @@ -68,7 +72,7 @@ def __getattr__(cls, name): | |||
| # -- General configuration ------------------------------------------------ | |||
|
|
|||
| # If your documentation needs a minimal Sphinx version, state it here. | |||
| needs_sphinx = '1.6' | |||
| needs_sphinx = "3.3" | |||
There was a problem hiding this comment.
I assume this matches the other PL repo sphinx versions?
There was a problem hiding this comment.
This is from Ali's request. #253 (comment)
There was a problem hiding this comment.
This is the minimum Sphinx version in PL too; see https://github.com/PennyLaneAI/pennylane/blob/d29142589078a1508b2aa7bfe7906311e0d728b3/doc/conf.py#L27
| @@ -231,22 +231,22 @@ def __getattr__(cls, name): | |||
| "download_button": "#19b37b", | |||
| } | |||
|
|
|||
| edit_on_github_project = 'XanaduAI/pennylane-lightning' | |||
| edit_on_github_branch = 'master/doc' | |||
| edit_on_github_project = "PennyLaneAI/pennylane-lightning" | |||
There was a problem hiding this comment.
Thanks, but is it from Ali 😄
chaeyeunpark
changed the title
chaeyeunpark
changed the title
chaeyeunpark
changed the title
|
Hi @mlxd, I have cleared documents and renamed the PR. The documentation for adding kernel remains the same in this PR but will be changed in a subsequent PR. |
There was a problem hiding this comment.
Great work @chaeyeunpark! I couldn't find anything else to add.
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
testsdirectory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs.Ensure that the test suite passes, by running
make test.Add a new entry to the
.github/CHANGELOG.mdfile, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context: As PR #245 becomes too huge, splitting is required. This is the first part of it.
Description of the Change: There are miscellaneous changes. Some are listed below:
.clang-tidyand source code accordingly.docare formatted.Test_GateImplementations_CompareKernels.cpp)tests/test_measure.py(a single qubit state is provided butdev.probabilityis called with two wires)Benefits:
Possible Drawbacks:
Related GitHub Issues: