-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Docker support #234
Add Docker support #234
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov Report
@@ Coverage Diff @@
## master #234 +/- ##
=======================================
Coverage 99.71% 99.71%
=======================================
Files 4 4
Lines 354 354
=======================================
Hits 353 353
Misses 1 1
Continue to review full report at Codecov.
|
…htning into add_dockerfile
…htning into add_dockerfile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @maliasadi thanks for putting this together.
Just curious, how does one expect to use the Docker version of lightning?
Will this be strictly used for building wheels, building and running the test-suite, or having a fully capable Python environment with lightning installed from the given branch?
Hey @mlxd. Thanks for the review. The main benefit of having such Docker file is that it eases the process of building an image with Python and Lightning installed in it. This may help developers to create images of their work and test on different machines. However, as told you before, I'm not sure if it's worth to be added to the master branch; as its use case for me is on AWS only. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @maliasadi . I think it will be useful for local testing and dev also.
I'd suggest one change, placing the Dockerfile
into a directory called docker
in the same structure as the PennyLane repo. Happy to approve it and let it be merged after this.
Context:
Add Docker support to setup & test PL-Lightning.
Description of the Change:
cmake/process_options.cmake
setup.py