Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload wheels to PyPI from GitHub workflows #220

Merged
merged 35 commits into from
Feb 8, 2022
Merged

Conversation

chaeyeunpark
Copy link
Contributor

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2022

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@codecov
Copy link

codecov bot commented Feb 1, 2022

Codecov Report

Merging #220 (613035e) into master (8b9d412) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #220   +/-   ##
=======================================
  Coverage   99.71%   99.71%           
=======================================
  Files           4        4           
  Lines         351      351           
=======================================
  Hits          350      350           
  Misses          1        1           
Impacted Files Coverage Δ
pennylane_lightning/_version.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b9d412...613035e. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2022

Test Report (C++) on Ubuntu

       1 files  ±0         1 suites  ±0   0s ⏱️ ±0s
   294 tests ±0     294 ✔️ ±0  0 💤 ±0  0 ±0 
2 677 runs  ±0  2 677 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 613035e. ± Comparison against base commit 8b9d412.

♻️ This comment has been updated with latest results.

@chaeyeunpark chaeyeunpark requested a review from mlxd February 2, 2022 14:30
@chaeyeunpark
Copy link
Contributor Author

Hi @mlxd, it now seems to work (see forked repository which uploads Pennylane-Lightning-Test to test-PyPI well (https://github.com/chaeyeunpark/pennylane-lightning/actions). If this looks okay, I want to change test-PyPI to real PyPI and merge.

@chaeyeunpark chaeyeunpark marked this pull request as ready for review February 2, 2022 15:45
@chaeyeunpark chaeyeunpark changed the title [WIP] Upload wheels to PyPI from GitHub workflows Upload wheels to PyPI from GitHub workflows Feb 2, 2022
Copy link
Member

@mlxd mlxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @chaeyeunpark
Looks good to me! I think we may update this after the current release cycle (ie once the 0.22.0-dev branch is onboard) to simplify the changing in naming. Do you think that sounds reasonable?

Otherwise, we can merge now and backport the change to the 0.21.0-rc0 branch without the dev name. Happy with whichever you think is best here. I'll approve after this decision.

@chaeyeunpark
Copy link
Contributor Author

Hi @mlxd, the current script does not update the version if it is not a dev version. As it also uploads wheels to PyPI only when it is released or merged into the master, it might be nice to test this feature with the rc build.

@mlxd
Copy link
Member

mlxd commented Feb 3, 2022

Hi @mlxd, the current script does not update the version if it is not a dev version. As it also uploads wheels to PyPI only when it is released or merged into the master, it might be nice to test this feature with the rc build.

Great, thanks @chaeyeunpark ! I think we can merge this safely on Monday/Tuesday, once we increment the master version to 0.22.0-dev. How does that sound to you?

@chaeyeunpark
Copy link
Contributor Author

@mlxd Yes, that sounds more safe 👍

@chaeyeunpark chaeyeunpark requested a review from mlxd February 8, 2022 16:40
Copy link
Member

@mlxd mlxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@chaeyeunpark chaeyeunpark merged commit 3f64ac4 into master Feb 8, 2022
@chaeyeunpark chaeyeunpark deleted the ci_upload_pypi branch February 8, 2022 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants