Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix windows bug #218

Merged
merged 7 commits into from
Feb 1, 2022
Merged

Fix windows bug #218

merged 7 commits into from
Feb 1, 2022

Conversation

chaeyeunpark
Copy link
Contributor

@chaeyeunpark chaeyeunpark commented Jan 31, 2022

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues: Closes #209

@github-actions
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@codecov
Copy link

codecov bot commented Jan 31, 2022

Codecov Report

Merging #218 (cf1911f) into master (c420034) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #218   +/-   ##
=======================================
  Coverage   99.65%   99.65%           
=======================================
  Files           4        4           
  Lines         293      293           
=======================================
  Hits          292      292           
  Misses          1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c420034...cf1911f. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 31, 2022

Test Report (C++) on Ubuntu

       1 files  ±0         1 suites  ±0   0s ⏱️ ±0s
   294 tests ±0     294 ✔️ ±0  0 💤 ±0  0 ±0 
2 677 runs  ±0  2 677 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit cf1911f. ± Comparison against base commit c420034.

♻️ This comment has been updated with latest results.

@chaeyeunpark chaeyeunpark requested a review from mlxd February 1, 2022 13:29
Copy link
Member

@mlxd mlxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good - nice one @chaeyeunpark

@chaeyeunpark
Copy link
Contributor Author

Thanks @mlxd !

@chaeyeunpark chaeyeunpark merged commit 4cad124 into master Feb 1, 2022
@chaeyeunpark chaeyeunpark deleted the fix_windows_bug branch February 1, 2022 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pytest fails on Windows
2 participants