-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QA docs #1035
base: v0.40.0_docs
Are you sure you want to change the base?
QA docs #1035
Conversation
Don't forget to increase the rc version number. |
…tning into tn-doc-update
…tning into tn-doc-update
…tning into tn-doc-update
…tning into tn-doc-update
…tning into tn-doc-update
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v0.40.0_docs #1035 +/- ##
=============================================
Coverage 27.36% 27.36%
=============================================
Files 29 29
Lines 2646 2646
=============================================
Hits 724 724
Misses 1922 1922 ☔ View full report in Codecov by Sentry. |
Looks like that few operations ( |
@multiphaseCFD I am not sure why |
This PR is for docs exclusively. what's your opinion on add |
I already asked @maliasadi and he told me the following: The |
Let's double check the render together and merge it to doc branch. @LuisAlfredoNu |
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
tests
directory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs
.Ensure that the test suite passes, by running
make test
.Add a new entry to the
.github/CHANGELOG.md
file, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format
.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues:
[sc-81816]