Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA docs #1035

Open
wants to merge 31 commits into
base: v0.40.0_docs
Choose a base branch
from
Open

QA docs #1035

wants to merge 31 commits into from

Conversation

josephleekl
Copy link
Contributor

@josephleekl josephleekl commented Jan 9, 2025

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

[sc-81816]

README.rst Outdated Show resolved Hide resolved
@multiphaseCFD multiphaseCFD added the urgent Mark a pull request as high priority label Jan 9, 2025
@multiphaseCFD
Copy link
Member

Don't forget to increase the rc version number.

@multiphaseCFD multiphaseCFD requested a review from a team January 9, 2025 19:36
README.rst Outdated Show resolved Hide resolved
README.rst Show resolved Hide resolved
README.rst Show resolved Hide resolved
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 27.36%. Comparing base (2a1488c) to head (62ebadf).

Files with missing lines Patch % Lines
pennylane_lightning/lightning_tensor/_tensornet.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           v0.40.0_docs    #1035   +/-   ##
=============================================
  Coverage         27.36%   27.36%           
=============================================
  Files                29       29           
  Lines              2646     2646           
=============================================
  Hits                724      724           
  Misses             1922     1922           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@josephleekl josephleekl marked this pull request as ready for review January 9, 2025 21:28
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
@multiphaseCFD
Copy link
Member

Looks like that few operations (qml.StatePrep) supported by LK are not listed in the device.rst

README.rst Outdated Show resolved Hide resolved
@LuisAlfredoNu
Copy link
Contributor

LuisAlfredoNu commented Jan 10, 2025

Looks like that few operations (qml.StatePrep) supported by LK are not listed in the device.rst

@multiphaseCFD I am not sure why StatePrep is not listed in the toml files of any device. However, should we add it to the documentation right?

@multiphaseCFD
Copy link
Member

Looks like that few operations (qml.StatePrep) supported by LK are not listed in the device.rst

@multiphaseCFD I am not sure why StatePrep is not listed in the toml files of any device. However, should we add it to the documentation right?

This PR is for docs exclusively. what's your opinion on add qml.stateprep to docs at this stage @maliasadi?

@LuisAlfredoNu
Copy link
Contributor

Looks like that few operations (qml.StatePrep) supported by LK are not listed in the device.rst

@multiphaseCFD I am not sure why StatePrep is not listed in the toml files of any device. However, should we add it to the documentation right?

This PR is for docs exclusively. what's your opinion on add qml.stateprep to docs at this stage @maliasadi?

I already asked @maliasadi and he told me the following: The statePrep is a special case of the gate because LQ devices are only available as a first gate on the circuit, otherwise this will decompose but we don't have support for that. This is why we do not have full support as a gate,. In conclusion, we don't have to include it in the documentation list of gates. 🚀

@multiphaseCFD
Copy link
Member

Let's double check the render together and merge it to doc branch. @LuisAlfredoNu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
urgent Mark a pull request as high priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants