Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create v0.40.0 Doc branch #1034

Draft
wants to merge 3 commits into
base: v0.40.0_rc
Choose a base branch
from
Draft

Create v0.40.0 Doc branch #1034

wants to merge 3 commits into from

Conversation

multiphaseCFD
Copy link
Member

@multiphaseCFD multiphaseCFD commented Jan 9, 2025

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

@multiphaseCFD multiphaseCFD added the urgent Mark a pull request as high priority label Jan 9, 2025
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@multiphaseCFD multiphaseCFD requested review from maliasadi and a team January 9, 2025 19:30
Copy link
Contributor

@LuisAlfredoNu LuisAlfredoNu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thank you @multiphaseCFD

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.36%. Comparing base (87619f9) to head (2a1488c).

Additional details and impacted files
@@             Coverage Diff             @@
##           v0.40.0_rc    #1034   +/-   ##
===========================================
  Coverage       27.36%   27.36%           
===========================================
  Files              29       29           
  Lines            2646     2646           
===========================================
  Hits              724      724           
  Misses           1922     1922           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@josephleekl josephleekl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @multiphaseCFD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
urgent Mark a pull request as high priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants