Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump pennylane requirement to v0.40 #1033

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

josephleekl
Copy link
Contributor

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

@josephleekl josephleekl added the do not merge Do not merge PR until this label is removed label Jan 9, 2025
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.36%. Comparing base (d8461f3) to head (cdd4007).
Report is 4 commits behind head on v0.40.0_rc.

❗ There is a different number of reports uploaded between BASE (d8461f3) and HEAD (cdd4007). Click for more details.

HEAD has 113 uploads less than BASE
Flag BASE (d8461f3) HEAD (cdd4007)
119 6
Additional details and impacted files
@@               Coverage Diff               @@
##           v0.40.0_rc    #1033       +/-   ##
===============================================
- Coverage       97.93%   27.36%   -70.58%     
===============================================
  Files             233       29      -204     
  Lines           39988     2646    -37342     
===============================================
- Hits            39162      724    -38438     
- Misses            826     1922     +1096     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@multiphaseCFD
Copy link
Member

Thanks @josephleekl. Don't forget to change the version from rc{n} to rc{n+1}.

@multiphaseCFD multiphaseCFD added the urgent Mark a pull request as high priority label Jan 9, 2025
@josephleekl josephleekl removed the urgent Mark a pull request as high priority label Jan 10, 2025
@multiphaseCFD multiphaseCFD changed the base branch from v0.40.0_rc to master January 10, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge Do not merge PR until this label is removed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants