Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate aarch64-cuda-wheels tests #1031

Merged
merged 38 commits into from
Jan 8, 2025
Merged

Conversation

multiphaseCFD
Copy link
Member

@multiphaseCFD multiphaseCFD commented Jan 6, 2025

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:

[sc-81544] & [sc-81555]

This PR fixes the python cuda dependecies bug and automates the arm64 LT and LGPU wheels tests

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

Copy link
Contributor

github-actions bot commented Jan 6, 2025

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@multiphaseCFD multiphaseCFD self-assigned this Jan 6, 2025
@multiphaseCFD multiphaseCFD added the ci:build_wheels Activate wheel building. label Jan 6, 2025
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.96%. Comparing base (0be5674) to head (107d16e).
Report is 1 commits behind head on v0.40.0_rc.

Additional details and impacted files
@@               Coverage Diff               @@
##           v0.40.0_rc    #1031       +/-   ##
===============================================
+ Coverage       27.36%   91.96%   +64.60%     
===============================================
  Files              29      112       +83     
  Lines            2646    16990    +14344     
===============================================
+ Hits              724    15625    +14901     
+ Misses           1922     1365      -557     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@multiphaseCFD multiphaseCFD added the urgent Mark a pull request as high priority label Jan 7, 2025
Copy link
Member

@maliasadi maliasadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🙌

.github/workflows/wheel_linux_aarch64_cuda.yml Outdated Show resolved Hide resolved
.github/workflows/wheel_linux_aarch64_cuda.yml Outdated Show resolved Hide resolved
CMakeLists.txt Show resolved Hide resolved
.github/workflows/wheel_linux_aarch64_cuda.yml Outdated Show resolved Hide resolved
@multiphaseCFD multiphaseCFD added the ci:use-gpu-runner Enable usage of GPU runner for this Pull Request label Jan 7, 2025
@multiphaseCFD multiphaseCFD changed the base branch from master to v0.40.0_rc January 8, 2025 14:14
Copy link
Contributor

@josephleekl josephleekl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @multiphaseCFD!!

.github/CHANGELOG.md Outdated Show resolved Hide resolved
.github/CHANGELOG.md Outdated Show resolved Hide resolved
.github/workflows/wheel_linux_aarch64_cuda.yml Outdated Show resolved Hide resolved
Copy link
Member

@maliasadi maliasadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@multiphaseCFD multiphaseCFD merged commit 87619f9 into v0.40.0_rc Jan 8, 2025
94 checks passed
@multiphaseCFD multiphaseCFD deleted the aarch64_gpu_wheels_tests branch January 8, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:build_wheels Activate wheel building. ci:use-gpu-runner Enable usage of GPU runner for this Pull Request urgent Mark a pull request as high priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants