Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the CaptureMPSState() API to LT #1028

Merged
merged 7 commits into from
Dec 18, 2024
Merged

Add the CaptureMPSState() API to LT #1028

merged 7 commits into from
Dec 18, 2024

Conversation

multiphaseCFD
Copy link
Member

@multiphaseCFD multiphaseCFD commented Dec 17, 2024

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:

[SC-80074]

Replace the dummy_tensor_update method with the cutensornetStateCaptureMPSAPI released cutensornet-v24.11 to ensure that further gates apply is allowed after the cutensornetStateCompute call.

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

@multiphaseCFD multiphaseCFD added the ci:use-gpu-runner Enable usage of GPU runner for this Pull Request label Dec 17, 2024
@multiphaseCFD multiphaseCFD marked this pull request as ready for review December 17, 2024 18:33
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.44%. Comparing base (42d3b8e) to head (346cf37).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1028      +/-   ##
==========================================
- Coverage   96.05%   92.44%   -3.62%     
==========================================
  Files         233      113     -120     
  Lines       39003    17065   -21938     
==========================================
- Hits        37465    15776   -21689     
+ Misses       1538     1289     -249     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@josephleekl josephleekl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks @multiphaseCFD

Copy link
Contributor

@LuisAlfredoNu LuisAlfredoNu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @multiphaseCFD
Nice simplification of LT

@multiphaseCFD multiphaseCFD merged commit 9f3cf06 into master Dec 18, 2024
64 of 65 checks passed
@multiphaseCFD multiphaseCFD deleted the add_mps_capture branch December 18, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:use-gpu-runner Enable usage of GPU runner for this Pull Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants