Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python CUDA dependencies as Lightning-GPU and Lightning-Tensor wheel dependencies #1025

Merged
merged 36 commits into from
Jan 3, 2025

Conversation

josephleekl
Copy link
Contributor

@josephleekl josephleekl commented Dec 13, 2024

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:

Description of the Change:
Added all Python CUDA dependencies to pyproject.toml for LGPU and LT. INSTALL_RPATH updated in CMake files.

Benefits:

Possible Drawbacks:

Related GitHub Issues:

[sc-79647]

@josephleekl josephleekl added the ci:build_wheels Activate wheel building. label Dec 13, 2024
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.20%. Comparing base (87bcd10) to head (7bc739a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1025      +/-   ##
==========================================
- Coverage   97.93%   96.20%   -1.74%     
==========================================
  Files         233      147      -86     
  Lines       39988    22632   -17356     
==========================================
- Hits        39162    21772   -17390     
- Misses        826      860      +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@multiphaseCFD
Copy link
Member

Thanks @josephleekl ! Would this new change let our users to run LT on google colab?

scripts/configure_pyproject_toml.py Show resolved Hide resolved
scripts/configure_pyproject_toml.py Show resolved Hide resolved
scripts/configure_pyproject_toml.py Outdated Show resolved Hide resolved
@josephleekl josephleekl added the draft Indicates that the PR is still in draft mode, but needs CIs. label Dec 16, 2024
@josephleekl
Copy link
Contributor Author

Thanks @josephleekl ! Would this new change let our users to run LT on google colab?

Possibly; here we explicitly set cusparse and nvjitlink as dependencies. The exact version is not specified and I'm not sure which pairing works on google colab!

@josephleekl josephleekl removed the draft Indicates that the PR is still in draft mode, but needs CIs. label Dec 16, 2024
@josephleekl josephleekl marked this pull request as ready for review December 16, 2024 23:41
Copy link
Member

@multiphaseCFD multiphaseCFD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @josephleekl for the nice work!

@multiphaseCFD multiphaseCFD added ci:use-gpu-runner Enable usage of GPU runner for this Pull Request ci:use-multi-gpu-runner Enable usage of Multi-GPU runner for this Pull Request labels Jan 2, 2025
Copy link
Contributor

@LuisAlfredoNu LuisAlfredoNu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks @josephleekl and @multiphaseCFD

Copy link
Member

@multiphaseCFD multiphaseCFD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! Thank you @josephleekl .

@multiphaseCFD multiphaseCFD merged commit d8461f3 into master Jan 3, 2025
105 of 106 checks passed
@multiphaseCFD multiphaseCFD deleted the cuda-wheel-dep branch January 3, 2025 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:build_wheels Activate wheel building. ci:use-gpu-runner Enable usage of GPU runner for this Pull Request ci:use-multi-gpu-runner Enable usage of Multi-GPU runner for this Pull Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants