Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Exact TN to docs #1021

Merged
merged 25 commits into from
Dec 13, 2024
Merged

Add Exact TN to docs #1021

merged 25 commits into from
Dec 13, 2024

Conversation

multiphaseCFD
Copy link
Member

@multiphaseCFD multiphaseCFD commented Dec 9, 2024

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:

[sc-72893]

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.45%. Comparing base (954a6e7) to head (10faba1).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (954a6e7) and HEAD (10faba1). Click for more details.

HEAD has 35 uploads less than BASE
Flag BASE (954a6e7) HEAD (10faba1)
41 6
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1021       +/-   ##
===========================================
- Coverage   95.50%   27.45%   -68.06%     
===========================================
  Files         178       29      -149     
  Lines       28357     2637    -25720     
===========================================
- Hits        27083      724    -26359     
- Misses       1274     1913      +639     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@multiphaseCFD multiphaseCFD marked this pull request as ready for review December 9, 2024 21:06
Copy link
Member

@maliasadi maliasadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @multiphaseCFD! Ping me for the second round 🙂

doc/lightning_tensor/device.rst Outdated Show resolved Hide resolved
doc/lightning_tensor/device.rst Outdated Show resolved Hide resolved
doc/lightning_tensor/device.rst Outdated Show resolved Hide resolved
doc/lightning_tensor/device.rst Show resolved Hide resolved
doc/lightning_tensor/device.rst Outdated Show resolved Hide resolved
doc/lightning_tensor/device.rst Outdated Show resolved Hide resolved
doc/lightning_tensor/device.rst Outdated Show resolved Hide resolved
doc/lightning_tensor/device.rst Outdated Show resolved Hide resolved
Copy link
Member

@maliasadi maliasadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ⭐ We need one more approval from @DSGuala or @AntonNI8 to merge the PR.

doc/lightning_tensor/device.rst Outdated Show resolved Hide resolved
doc/lightning_tensor/device.rst Outdated Show resolved Hide resolved
multiphaseCFD and others added 2 commits December 11, 2024 14:09
Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com>
@multiphaseCFD multiphaseCFD requested review from DSGuala and tomlqc and removed request for DSGuala and tomlqc December 12, 2024 14:45
multiphaseCFD and others added 3 commits December 13, 2024 13:45
Co-authored-by: ANTH0NY <39093564+AntonNI8@users.noreply.github.com>
Co-authored-by: ANTH0NY <39093564+AntonNI8@users.noreply.github.com>
Co-authored-by: ANTH0NY <39093564+AntonNI8@users.noreply.github.com>
@multiphaseCFD multiphaseCFD merged commit e9a3b80 into master Dec 13, 2024
69 of 70 checks passed
@multiphaseCFD multiphaseCFD deleted the lt_tn_docs_v0 branch December 13, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants