Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Plugin Test Matrix stable/stable tests #1019

Merged
merged 8 commits into from
Dec 6, 2024
Merged

Conversation

AmintorDusko
Copy link
Contributor

@AmintorDusko AmintorDusko commented Dec 6, 2024

Context: The plugin test matrix fails because of a recent pin to jaxlib version.

Description of the Change: We'll follow the pennylane and Catalyst pins.

stable/stable

Benefits: Tests will work.

Possible Drawbacks:

Related GitHub Issues:

[sc-79942]

.github/CHANGELOG.md Outdated Show resolved Hide resolved
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.86%. Comparing base (5448c8a) to head (df1f904).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (5448c8a) and HEAD (df1f904). Click for more details.

HEAD has 21 uploads less than BASE
Flag BASE (5448c8a) HEAD (df1f904)
27 6
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1019       +/-   ##
===========================================
- Coverage   96.73%   27.86%   -68.88%     
===========================================
  Files         233       29      -204     
  Lines       39639     2584    -37055     
===========================================
- Hits        38345      720    -37625     
- Misses       1294     1864      +570     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AmintorDusko AmintorDusko added do not merge Do not merge PR until this label is removed draft Indicates that the PR is still in draft mode, but needs CIs. and removed do not merge Do not merge PR until this label is removed labels Dec 6, 2024
@AmintorDusko AmintorDusko marked this pull request as ready for review December 6, 2024 15:54
@AmintorDusko AmintorDusko removed the draft Indicates that the PR is still in draft mode, but needs CIs. label Dec 6, 2024
Copy link
Member

@maliasadi maliasadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AmintorDusko! 🥇

.github/CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com>
Copy link
Contributor

@LuisAlfredoNu LuisAlfredoNu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @AmintorDusko
Just one comment

requirements-dev.txt Show resolved Hide resolved
Copy link
Contributor

@LuisAlfredoNu LuisAlfredoNu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @AmintorDusko for this CI fix. 🚀

@AmintorDusko AmintorDusko merged commit 9eb6123 into master Dec 6, 2024
69 of 70 checks passed
@AmintorDusko AmintorDusko deleted the fix/stable-stable branch December 6, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants