-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework expectation values using Cirq simulators #81
Conversation
Codecov Report
@@ Coverage Diff @@
## master #81 +/- ##
==========================================
+ Coverage 99.14% 99.23% +0.09%
==========================================
Files 8 8
Lines 349 391 +42
==========================================
+ Hits 346 388 +42
Misses 3 3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @rmoyard. Great job getting this to work. 🚀
Just have a few comments/questions on a few things. Mainly code-quality things. Regarding the failing device suite test, I'm not sure what to do. It seems like something that might need to be fixed on the Cirq side. 🤔
Co-authored-by: Theodor <theodor@xanadu.ai>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @rmoyard, this is looking nice altogether! 💯 🙂 Left some comments with suggestions. Most of these include thoughts on readability and testing.
Co-authored-by: antalszava <antalszava@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! 💯 🎉 Awesome to have this in. 🙂 Had two minor comments, happy for this to be merged from my side afterwards.
Co-authored-by: antalszava <antalszava@gmail.com>
This PR aims to update the way
expval
is evaluated, it can now usesimulate_expectation_values
from Cirq instead of the PennyLane function forcirq.simulator
andcirq.mixedsimulator
forshots
andshots=None
. It is directly related to issue #70.