Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update requirements to Cirq==0.12 #77

Merged
merged 6 commits into from
Aug 19, 2021
Merged

Update requirements to Cirq==0.12 #77

merged 6 commits into from
Aug 19, 2021

Conversation

rmoyard
Copy link
Contributor

@rmoyard rmoyard commented Aug 18, 2021

No description provided.

@codecov
Copy link

codecov bot commented Aug 18, 2021

Codecov Report

Merging #77 (aa90bb2) into master (3723cb1) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #77   +/-   ##
=======================================
  Coverage   99.14%   99.14%           
=======================================
  Files           8        8           
  Lines         349      349           
=======================================
  Hits          346      346           
  Misses          3        3           
Impacted Files Coverage Δ
pennylane_cirq/_version.py 100.00% <100.00%> (ø)
pennylane_cirq/cirq_device.py 98.90% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3723cb1...aa90bb2. Read the comment docs.

@rmoyard rmoyard requested a review from antalszava August 18, 2021 20:29
Copy link
Contributor

@antalszava antalszava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 💯 Give me a ping when merging this and we can do the release. :)

Comment on lines +111 to +112
for key, value in self._operation_map.items():
if not value:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was the reason to make these changes improving code quality?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No CodeFactor was not happy about it and was failing...

@rmoyard rmoyard merged commit e5a04d0 into master Aug 19, 2021
@rmoyard rmoyard deleted the cirq12 branch August 19, 2021 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants