Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update simulator_device.py #58

Merged
merged 3 commits into from
Apr 20, 2021
Merged

Update simulator_device.py #58

merged 3 commits into from
Apr 20, 2021

Conversation

chaserileyroberts
Copy link

shots=1000 -> shots=None

@codecov
Copy link

codecov bot commented Apr 12, 2021

Codecov Report

Merging #58 (ecef851) into master (84c4e8b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #58   +/-   ##
=======================================
  Coverage   99.10%   99.10%           
=======================================
  Files           8        8           
  Lines         334      334           
=======================================
  Hits          331      331           
  Misses          3        3           
Impacted Files Coverage Δ
pennylane_cirq/pasqal_device.py 100.00% <100.00%> (ø)
pennylane_cirq/qsim_device.py 96.55% <100.00%> (ø)
pennylane_cirq/simulator_device.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84c4e8b...ecef851. Read the comment docs.

Copy link
Contributor

@trbromley trbromley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Thenerdstation! We also need this on the other devices:

  • QSimDevice
  • QSimhDevice
  • PasqalDevice
  • MixedStateSimulatorDevice

Also, what about adding a quick test? I was surprised the tests were still passing with non-analytic being the default, but this is because we never check the default for shots and always explicitly pass. So even a test where we don't pass a shots argument but we check that dev.shots is None?

@josh146 josh146 merged commit 4a527b9 into master Apr 20, 2021
@josh146 josh146 deleted the Thenerdstation-patch-1 branch April 20, 2021 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants