Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove import of qsimcirq from __init__ #46

Merged
merged 3 commits into from
Nov 10, 2020
Merged

Conversation

thisac
Copy link
Contributor

@thisac thisac commented Nov 9, 2020

Removes the import of qsimcirq from the __init__.py file and fixes the tests and entrypoints to import qsimcirq correctly.

This avoids users having to install qsimcirq for the other Cirq devices to work.

@thisac thisac requested a review from co9olguy November 9, 2020 20:52
@thisac thisac self-assigned this Nov 9, 2020
@codecov
Copy link

codecov bot commented Nov 9, 2020

Codecov Report

Merging #46 (a11239b) into master (a401c94) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #46      +/-   ##
==========================================
- Coverage   99.07%   99.07%   -0.01%     
==========================================
  Files           8        8              
  Lines         324      323       -1     
==========================================
- Hits          321      320       -1     
  Misses          3        3              
Impacted Files Coverage Δ
pennylane_cirq/__init__.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a401c94...a11239b. Read the comment docs.

@mariaschuld mariaschuld merged commit d7c3dde into master Nov 10, 2020
@mariaschuld mariaschuld deleted the fix-import-qsim branch November 10, 2020 06:36
@josh146
Copy link
Member

josh146 commented Nov 13, 2020

@thisac don't forget to also update the changelog! As the number of plugins increases, this becomes more important so as to ensure that we can keep track of changes + when pypi releases are required

@co9olguy
Copy link
Member

@josh146 I wonder if we can set up a GitHub action that checks whether there are any updates to CHANGELOG?

@josh146
Copy link
Member

josh146 commented Nov 14, 2020

Yes! @mariaschuld and I were discussing this recently.

I think the best approach is to have a bot comment a reminder when PRs are opened, rather than have a check that must pass for merging (avoids complexity, and allows for trivial PRs where we don't want to necessarily update the changelog).

See https://github.com/marketplace/actions/changelog-reminder:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants