Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete references to the removed QubitStateVector class #203

Merged
merged 6 commits into from
Nov 14, 2024

Conversation

andrijapau
Copy link
Contributor

Context:

Completing the deprecation cycle of QubitStateVector (see PennyLaneAI/pennylane#6525)

Description of the Change:

Removed all references to the deprecated source code.

[sc-77482]

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.42%. Comparing base (86740c4) to head (d5417d6).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #203   +/-   ##
=======================================
  Coverage   99.42%   99.42%           
=======================================
  Files           8        8           
  Lines         350      350           
=======================================
  Hits          348      348           
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mudit2812 mudit2812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change requested, otherwise LGTM

CHANGELOG.md Show resolved Hide resolved
pennylane_cirq/cirq_device.py Outdated Show resolved Hide resolved
andrijapau and others added 2 commits November 13, 2024 10:25
Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai>
Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai>
@andrijapau andrijapau requested a review from mudit2812 November 13, 2024 15:26
Copy link
Contributor

@mudit2812 mudit2812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are more places in cirq_device.py with references to qubit_state_vector_operation that should be updated to state_prep_operation.

@andrijapau andrijapau requested a review from mudit2812 November 13, 2024 15:37
@andrijapau
Copy link
Contributor Author

There are more places in cirq_device.py with references to qubit_state_vector_operation that should be updated to state_prep_operation.

Oops, sorry. They should all be sorted now with a find/replace. Thanks!!

@andrijapau andrijapau merged commit e94c315 into master Nov 14, 2024
9 checks passed
@andrijapau andrijapau deleted the remove-qsv branch November 14, 2024 17:19
andrijapau added a commit to PennyLaneAI/pennylane that referenced this pull request Nov 14, 2024
**Context:**

Completing the deprecation cycle of `QubitStateVector`.

**Description of the Change:**

1. Update `deprecations.rst`
2. Update `changelog-dev.md`
3. Remove all deprecated source code

Also, updated CI to install *latest* `pennylane-qiskit` rather than
stable.

References found in,
- Catalyst:  PennyLaneAI/catalyst#1289
- Lightning: PennyLaneAI/pennylane-lightning#985
- AQT: PennyLaneAI/pennylane-aqt#77
- Qulacs: PennyLaneAI/pennylane-qulacs#83
- Qiskit: PennyLaneAI/pennylane-qiskit#601
- Cirq: PennyLaneAI/pennylane-cirq#203

No references found in,
- QML


[sc-77482]

---------

Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants