Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try bumping cirq_core #171

Merged
merged 13 commits into from
Jan 4, 2024
Merged

Try bumping cirq_core #171

merged 13 commits into from
Jan 4, 2024

Conversation

lillian542
Copy link
Contributor

@lillian542 lillian542 commented Dec 15, 2023

Bump cirq to version 1.3.0 in the requirements.txt files, and bump all the other things that need to be bumped to make that work.

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ead4c73) 99.43% compared to head (e53df73) 99.43%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #171   +/-   ##
=======================================
  Coverage   99.43%   99.43%           
=======================================
  Files           8        8           
  Lines         352      352           
=======================================
  Hits          350      350           
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

doc/requirements.txt Outdated Show resolved Hide resolved
requirements.txt Outdated Show resolved Hide resolved
doc/requirements.txt Outdated Show resolved Hide resolved
requirements.txt Outdated Show resolved Hide resolved
doc/requirements.txt Outdated Show resolved Hide resolved
doc/requirements.txt Outdated Show resolved Hide resolved
doc/requirements.txt Outdated Show resolved Hide resolved
doc/requirements.txt Outdated Show resolved Hide resolved
requirements.txt Outdated Show resolved Hide resolved
@lillian542 lillian542 requested a review from a team January 3, 2024 17:00
@timmysilv
Copy link
Contributor

not sure entirely how to handle this, but I tried to add cirq-core==1.3.0 to qml dependencies explicitly, and poetry gave me an error:

qml on  master [$!?] is 📦 v0.0.0 via 🐍 3.9.13 (.venv) took 17s 
❯ poetry add -G executable-dependencies cirq-core==1.3.0

Updating dependencies
Resolving dependencies... (1.0s)

Because cirq (1.0.0) depends on cirq-core (1.0.0)
 and no versions of cirq match >1.0.0,<1.1.0 || >1.1.0,<1.2.0 || >1.2.0,<1.3.0, cirq (>=1.0.0,<1.1.0 || >1.1.0,<1.2.0 || >1.2.0,<1.3.0) requires cirq-core (1.0.0).
And because cirq (1.2.0) depends on cirq-core (1.2.0), cirq (>=1.0.0,<1.1.0 || >1.1.0,<1.3.0) requires cirq-core (1.0.0 || 1.2.0).
And because cirq (1.1.0) depends on cirq-core (1.1.0)
 and mitiq (0.29.0) depends on cirq (>=1.0.0,<1.3.0), mitiq (0.29.0) requires cirq-core (1.0.0 || 1.1.0 || 1.2.0).
So, because qml depends on both mitiq (0.29.0) and cirq-core (1.3.0), version solving failed.

basically, we pin mitiq==0.29.0, and that needs cirq-corq<1.3.0. If we can bump mitiq to 0.32.0, we'll be fine. But the bigger question is, do we care? it's not an explicit requirement here anyway

Copy link
Contributor

@albi3ro albi3ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for actually doing this 🎉

@lillian542
Copy link
Contributor Author

not sure entirely how to handle this, but I tried to add cirq-core==1.3.0 to qml dependencies explicitly, and poetry gave me an error

note: we discussed offline and decided this is fine for now, something to think about standardizing going forward

@lillian542 lillian542 merged commit f78554a into master Jan 4, 2024
9 checks passed
@lillian542 lillian542 deleted the bump_cirq_core branch January 4, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants