Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove id gates hack from simulator dev #111

Merged
merged 4 commits into from
Aug 11, 2022

Conversation

cvqmm
Copy link
Contributor

@cvqmm cvqmm commented Aug 2, 2022

use qubit_order to remove identity gates hack from cirq simulator device

@antalszava antalszava requested review from Jaybsoni and rmoyard August 2, 2022 19:21
@antalszava
Copy link
Contributor

Hi @cvqmm, thanks for the contribution! We'll be leaving a review. It seems that the affected files may have to be formatted using black to pass the continuous integration check for formatting.

@codecov
Copy link

codecov bot commented Aug 2, 2022

Codecov Report

Merging #111 (75bd9bf) into master (34325cf) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #111      +/-   ##
==========================================
- Coverage   99.24%   99.23%   -0.01%     
==========================================
  Files           8        8              
  Lines         397      393       -4     
==========================================
- Hits          394      390       -4     
  Misses          3        3              
Impacted Files Coverage Δ
pennylane_cirq/simulator_device.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@Jaybsoni Jaybsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @cvqmm,

Thanks for the contribution! Glad we were able to get rid of that hack in the code. The contribution looks good to go.

Could you add an entry under the subheading "Improvements" in the CHANGELOG.md file, with a short description of the fix and a link to this PR. Don't forget to add your name to the contributors list at the bottom!

Once that's done I am happy to approve.
Cheers,

@cvqmm
Copy link
Contributor Author

cvqmm commented Aug 10, 2022

Hi @Jaybsoni,

thanks for the review! the fix's description is added to the change log in the last commit 75bd9bf

Regards,

Copy link
Contributor

@Jaybsoni Jaybsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 💯! @antalszava I think we will need an override for failing codecov.

@antalszava
Copy link
Contributor

Sure 👍 I can merge this once there's a 2nd review in.

Copy link
Contributor

@rmoyard rmoyard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me, thanks for the contribution!

@Jaybsoni Jaybsoni requested a review from antalszava August 10, 2022 16:24
@antalszava antalszava merged commit f0f6efd into PennyLaneAI:master Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants