-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove id gates hack from simulator dev #111
remove id gates hack from simulator dev #111
Conversation
Hi @cvqmm, thanks for the contribution! We'll be leaving a review. It seems that the affected files may have to be formatted using |
Codecov Report
@@ Coverage Diff @@
## master #111 +/- ##
==========================================
- Coverage 99.24% 99.23% -0.01%
==========================================
Files 8 8
Lines 397 393 -4
==========================================
- Hits 394 390 -4
Misses 3 3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @cvqmm,
Thanks for the contribution! Glad we were able to get rid of that hack in the code. The contribution looks good to go.
Could you add an entry under the subheading "Improvements" in the CHANGELOG.md
file, with a short description of the fix and a link to this PR. Don't forget to add your name to the contributors list at the bottom!
Once that's done I am happy to approve.
Cheers,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 💯! @antalszava I think we will need an override for failing codecov.
Sure 👍 I can merge this once there's a 2nd review in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me, thanks for the contribution!
use qubit_order to remove identity gates hack from cirq simulator device