-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove CPhase gate alias references #718
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #718 +/- ##
==========================================
- Coverage 98.07% 98.04% -0.03%
==========================================
Files 70 69 -1
Lines 9601 9536 -65
Branches 756 762 +6
==========================================
- Hits 9416 9350 -66
Misses 151 151
- Partials 34 35 +1 ☔ View full report in Codecov by Sentry. |
Hello. You may have forgotten to update the changelog!
|
|
Even for CPhase, we need to remove it from tomls contained in the Catalyst repo too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After #745 is merged and this PR is updated, one should run latest/latest/latest on this branch. I expect it to succeed. On #745 latest/latest/latest fails with the error message:
FAILED frontend/test/pytest/test_transform.py::TestBroadcastExpand::test_expansion_qnode_no_cache[lightning.kokkos-obs1-params2] - catalyst.utils.exceptions.CompileError: Gates in qml.device.operations and specification file do not match.
Gates that present only in the device: {'C(GlobalPhase)'}
Gates that present only in spec: set()
I am not asking for this to fix latest/latest/latest but merely to report what the outcome is on the channel so that we can fix it if this is not the case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I never actually reviewed it, just made the suggestion that it should fix the other issue.
@erick-xanadu I merged this PR with the recent main and solved the conflicts. The test you mentioned should pass now. |
Context: Transition to the quantum device config schema 2
Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues: