-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Frontend] Make tests toml-schema independent #712
Merged
Merged
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
0ede63d
Make a test tomle-schema-2-compatible
1babc99
Address formatting issues
30de70c
Make test toml-schema-independant
9f985b0
Merge branch 'main' into toml-schema-2-update-test
f97e7e9
Address codecov errors
40499b4
Address codecov errors
0ed92b6
Address codecov errors
22cfe45
Merge remote-tracking branch 'origin/main' into toml-schema-2-update-…
d00c7e4
Fix wrong field name
d3ffae5
Address review suggestions; Move code around
aa37716
Merge remote-tracking branch 'origin/main' into toml-schema-2-update-…
6537b2a
Address formatting issues
468c3ca
Address formatting issues
72c9f24
Address pylint issues
611e5fc
Add missing paths module
e94c55d
Merge branch 'main' into toml-schema-2-update-test
5bd08cb
Fix re-added runtime.py
f59e6bc
Fix a test
8aadcf4
Merge remote-tracking branch 'origin/main' into toml-schema-2-update-…
1ba9149
Update frontend/catalyst/jax_primitives.py
4735b85
Update frontend/catalyst/third_party/cuda/primitives/__init__.py
74ec4ff
Rename paths -> runtime_environment
8793214
Address review suggestions: move validate_device_requirements -> qjit…
04a5b41
Address review suggestions: remove self.qjit_device attribute from qn…
2bb3ede
Fix a test import
722886c
Merge branch 'main' into toml-schema-2-update-test
eadeb91
Update changelog
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reading this entry it sounds like it only concerns tests. Typically we exclude changelog entries for test-only, ci-only, doc-only, and repo-only changes.
Maybe the refactor can be mentioned in internal changes though? 🤔 New features, improvements, bug fixes should all be observable by the user in the distributed release in some way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the commit changed anything?