Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove test suite warning #566

Merged
merged 4 commits into from
Feb 29, 2024
Merged

Remove test suite warning #566

merged 4 commits into from
Feb 29, 2024

Conversation

rmoyard
Copy link
Contributor

@rmoyard rmoyard commented Feb 29, 2024

Description of the Change:

Removes cannot collect test class 'TestDevice' because it has a __init__ constructor (from: pytest/test_config_functions.py, pytest thinks TestDevice is a class containing test.

@rmoyard rmoyard requested a review from erick-xanadu February 29, 2024 17:27
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/changelog.md on your branch with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link
Contributor

@dime10 dime10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this has been bugging me too 😅 (although DeviceTest is a weird name?)

@rmoyard rmoyard marked this pull request as ready for review February 29, 2024 18:24
@rmoyard rmoyard requested a review from dime10 February 29, 2024 18:24
@rmoyard rmoyard merged commit 2689a35 into main Feb 29, 2024
37 checks passed
@rmoyard rmoyard deleted the remove_warning branch February 29, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants