Native quantum control toml #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #554 +/- ##
=======================================
Coverage 99.49% 99.50%
=======================================
Files 50 50
Lines 8745 8814 +69
Branches 624 648 +24
=======================================
+ Hits 8701 8770 +69
Misses 25 25
Partials 19 19 ☔ View full report in Codecov by Sentry. |
sergei-mironov
changed the base branch from
main
to
native-quantum-control-mlir
dime10
reviewed
Feb 27, 2024
sergei-mironov
force-pushed
the
native-quantum-control-toml
branch
from
7409fce to
526635c
Compare
dime10
reviewed
Mar 4, 2024
Co-authored-by: David Ittah <dime10@users.noreply.github.com>
added 11 commits
March 6, 2024 11:30
dime10
reviewed
Mar 6, 2024
dime10
reviewed
Mar 6, 2024
dime10
reviewed
Mar 6, 2024
Co-authored-by: David Ittah <dime10@users.noreply.github.com>
dime10
reviewed
Mar 12, 2024
dime10
reviewed
Mar 12, 2024
Co-authored-by: David Ittah <dime10@users.noreply.github.com>
dime10
reviewed
Mar 13, 2024
sergei-mironov
pushed a commit
that referenced
this pull request
Mar 20, 2024
**Context:** Ongoing transition to the schema 2 of the quantum device toml specification **Description of the Change:** This is a minor source code clean up PR. * Remove force addition of the ControlQubitUnitary gate to the set of QJITDevice operations. This gate is handled by the generic logic in schema 2 config loader. In schema 1 loader, the sources already have all the required patches. * Explicitly list the runtime-supported controlled gates * Fix missing Projector observable in the lightning-kokkos device config * Open toml files in binary mode (fixes wheel builds) * Update some comments and simplify the set calculations. * Includes Cuda hotfix, to be removed after #617 is merged **Benefits:** Cleaner sources **Possible Drawbacks:** N/A **Related GitHub Issues:** #554
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By this PR we change the TOML file schema in a way that allows us to represent quantum control at per-gate level.
[sc-57159]
[sc-57172]