Fix the default value of qubits_len for the qinst primitive
#496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two issues are being fixed: - The default value of `-1`, intended to represent all arguments are qubits, does not actually work. Instead, it introduces a off by one error, cutting off one of the qubit values. - The abstract evaluation did not work with the default value, and instead assumed the value was always set manually.
dime10
added
bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #496 +/- ##
=======================================
Coverage 99.57% 99.57%
=======================================
Files 43 43
Lines 7740 7740
Branches 533 533
=======================================
Hits 7707 7707
Misses 17 17
Partials 16 16 ☔ View full report in Codecov by Sentry. |
erick-xanadu
reviewed
Feb 5, 2024
Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two issues are being fixed:
-1, intended to represent all arguments arequbits, does not actually work. Instead, it introduces a off by one
error, cutting off one of the qubit values.
instead assumed the value was always set manually.
Credit to @positr0nium for unearthing this :)