Add Pauli Product dialect (QEC) #1486
Conversation
|
|
||
| func.func @foo(%q1 : !quantum.bit, %q2 : !quantum.bit) { | ||
| %theta = arith.constant 0.1 : f64 | ||
| qec.ppr [X, Z] (%theta) %q1, %q2 : !quantum.bit, !quantum.bit |
There was a problem hiding this comment.
Unfortunately I haven't been able to make this syntax for the PPMs work, I think there is an issue in MLIR with parsing an array attribute of enums. For example, if I build the op with a single Pauli letter instead of the array, the parsing of qec.ppr X (%theta) %q1, %q2 : !quantum.bit, !quantum.bit for example works just fine.
I also searched upstream for example dialects using array attributes of enums, and I did find linalg.generic and vector.contract using it. However, they both implemented custom parsers.
I think to get it working we could either implement a custom printer/parser or change to attribute to a different type, for example using strings for the Pauli letters (less efficient), or using integers directly to represent them instead of the enum (less readable).
There was a problem hiding this comment.
Hi @dime10. Thanks for implementing and detail this issue. I will take a look through the MLIR more detail and I'll keep you in loop.
|
Hello. You may have forgotten to update the changelog!
|
@sengthai We can use this as the target of our Pauli product passes. (feel free to adjust if the need arises)
[sc-82892]