Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebase Refactor passes module & clean-up exports with v0.10.0-rc #1432

Merged
merged 15 commits into from
Jan 9, 2025
Merged

Rebase Refactor passes module & clean-up exports with v0.10.0-rc #1432

merged 15 commits into from
Jan 9, 2025

Conversation

erick-xanadu
Copy link
Contributor

Context: Needed to rebase refactoring branch to test.

Description of the Change:

  • Adds documentation to Pass, PassPlugin
  • Uses values from Pass's options as options in the ApplyRegisteredPassOps

Benefits: Documentation, passes can have options.

@erick-xanadu erick-xanadu mentioned this pull request Jan 9, 2025
Closed
@erick-xanadu erick-xanadu added this to the v0.10.0 milestone Jan 9, 2025
@erick-xanadu erick-xanadu requested a review from dime10 January 9, 2025 19:49
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md on your branch with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

dime10
dime10 reviewed Jan 9, 2025
View reviewed changes
Copy link
Contributor

@dime10 dime10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you pull in ee3324c, that should fix the CI

frontend/test/pytest/test_mlir_plugin_interface.py Outdated Show resolved Hide resolved
frontend/catalyst/passes/pass_api.py Outdated Show resolved Hide resolved
dime10
dime10 approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@dime10 dime10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@erick-xanadu erick-xanadu merged commit 1d61d40 into v0.10.0-rc Jan 9, 2025
40 checks passed
@erick-xanadu erick-xanadu deleted the eochoa/2025-01-09/replace-other-branch branch January 9, 2025 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dime10 dime10 dime10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@erick-xanadu @dime10