Daily rc sync to main #1429
Merged
Daily rc sync to main #1429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
**Context:**  **Description of the Change:**  **Benefits:** No floating `}` and well formatted contents. **Possible Drawbacks:** Do we also want to show the libraries we use? **Related GitHub Issues:**
**Context:** Fix some typos and phrasing in the docs
…e file naming (#1405) **Context:** This PR fixes some small bugs or lack of documentation for catalyst-cli gathered from @dime10's feedbacks. - The `--help` flag seems to dump a lot of unrelated options which makes it difficult to navigate through catalyst options. - The possible stages for the --checkpoint-stage option are not mentioned in the documentation - When using `--checkpoint-stage`, `--save-ir-after-each=pipeline` no longer works. - The output from --save-ir-after-each=pass produces one output for each function when dealing with a function pass which results in a large number of outputs and one has to find the function of interest randomly. **Description of the Change:** - `--help` option now prints all the catalyst-cli specific options first before jumping into mlir-opt options - Added more details to documentation - Fixed the bug for `save-ir-after-each` and `save-ir-after-each` coexisting together. - Output from `save-ir-after-each` now appends the name of the function to the file name making it easier to identify the desired output. **Benefits:** easier experience for catalyst-cli user **Possible Drawbacks:** **Related GitHub Issues:** --------- Co-authored-by: Joey Carter <joseph.carter@xanadu.ai> Co-authored-by: erick-xanadu <110487834+erick-xanadu@users.noreply.github.com> Co-authored-by: David Ittah <dime10@users.noreply.github.com>
…ment (#1404) **Context:** The documentation for MLIR plugins did not state anything about `entry_points` nor relevant functions when loading MLIR plugins from python. Also changed the type of the `pass_pipeline` kwarg. Instead of it being a tuple of Passes, it is now a list of Passes. This is nicer for developers. **Description of the Change:** The `pass_pipeline` keyword argument is now a list instead of a tuple. This list is converted into a tuple at the moment the qnode primitive is bound. Added documentation for MLIR plugins. --------- Co-authored-by: Isaac De Vlugt <34751083+isaacdevlugt@users.noreply.github.com>
**Context:** PR #1387, adds support for static parameters in customOp. However support for GlobalPhase and MultiRZ gates are missing. **Description of the Change:** This PR adds support for the missing two gates. We unified the way `GlobalPhase` and `MultiRZ` are treated in the frontend. right now, GlobalPase has its own primitive (`qphase_p`) however `MultiRZ` is binded through the `qinst_p` primitive. `qphase_p` is now removed from frontend and binded through `qints_p` similar to MultiRZ. If a `MultiRZ` or `GlobalPhase` gate has static parameters parameters, a `staticCustomOp` is created which will be lowered to the respective gate in static_custom_lowering pass. **Benefits:** removed inconsistency in the definition of odd custom gates (MultiRZ and GlobalPhase) static circuit IR now supports more parameterized gates. **Possible Drawbacks:** **Related GitHub Issues:** --------- Co-authored-by: ringo-but-quantum <github-ringo-but-quantum@xanadu.ai> Co-authored-by: paul0403 <79805239+paul0403@users.noreply.github.com> Co-authored-by: Ritu Thombre <renitath99@gmail.com> Co-authored-by: Ritu Thombre <42207923+ritu-thombre99@users.noreply.github.com> Co-authored-by: lillian542 <38584660+lillian542@users.noreply.github.com> Co-authored-by: Joey Carter <joseph.carter@xanadu.ai> Co-authored-by: Raul Torres <138264735+rauletorresc@users.noreply.github.com> Co-authored-by: Isaac De Vlugt <34751083+isaacdevlugt@users.noreply.github.com> Co-authored-by: erick-xanadu <110487834+erick-xanadu@users.noreply.github.com>
Co-authored-by: Joey Carter <joseph.carter@xanadu.ai>
This reverts commit b3f4417.
joeycarter
approved these changes
Jan 9, 2025
|
Hello. You may have forgotten to update the changelog!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatic sync from the release candidate to main during a feature freeze.