Allow specifying a branch to switch to when setting up a dev environment from the wheels #1406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dime10
approved these changes
Jan 3, 2025
mehrdad2m
pushed a commit
that referenced
this pull request
Jan 6, 2025
…ent from the wheels (#1406) **Context:** Switching to a different branch after setting up the dev wheel environment would break the latter. **Description of the Change:** Accept a branch to switch to as an optional argument, and switch to it before hard-linking the frontend source code files. **Benefits:** Start working directly on an existing branch. **Possible Drawbacks:** Switching to another branch using git would keep breaking the installation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: Switching to a different branch after setting up the dev wheel environment would break the latter.
Description of the Change: Accept a branch to switch to as an optional argument, and switch to it before hard-linking the frontend source code files.
Benefits: Start working directly on an existing branch.
Possible Drawbacks: Switching to another branch using git would keep breaking the installation.