Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace pybind11 with nanobind in the OQC module #1391

Merged
merged 14 commits into from
Dec 19, 2024
Merged

Replace pybind11 with nanobind in the OQC module #1391

merged 14 commits into from
Dec 19, 2024

Conversation

rauletorresc
Copy link
Contributor

Context: OQC was still using pybind11, which made it incompatible with the stable ABI.

Description of the Change: Replace pybind11 with nanobind in the OQC module.

Benefits: Conforming with the stable ABI.

@rauletorresc rauletorresc added the author:build-wheels Run the wheel building workflows on this Pull Request label Dec 18, 2024
@rauletorresc rauletorresc requested a review from a team December 18, 2024 21:11
@rauletorresc rauletorresc self-assigned this Dec 18, 2024
@rauletorresc rauletorresc mentioned this pull request Dec 18, 2024
Merged
dime10
dime10 requested changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@dime10 dime10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rauletorresc!

frontend/catalyst/third_party/oqc/src/tests/CMakeLists.txt Show resolved Hide resolved
frontend/catalyst/third_party/oqc/src/oqc_python_module.cpp Outdated Show resolved Hide resolved
frontend/catalyst/third_party/oqc/src/CMakeLists.txt Outdated Show resolved Hide resolved
frontend/catalyst/third_party/oqc/src/CMakeLists.txt Outdated Show resolved Hide resolved
frontend/catalyst/third_party/oqc/src/CMakeLists.txt Show resolved Hide resolved
@rauletorresc rauletorresc requested a review from dime10 December 19, 2024 04:05
@rauletorresc rauletorresc removed the author:build-wheels Run the wheel building workflows on this Pull Request label Dec 19, 2024
@rauletorresc rauletorresc added the author:build-wheels Run the wheel building workflows on this Pull Request label Dec 19, 2024
dime10
dime10 reviewed Dec 19, 2024
View reviewed changes
Copy link
Contributor

@dime10 dime10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Raul, I think we're nearly there 👍

frontend/catalyst/third_party/oqc/src/CMakeLists.txt Outdated Show resolved Hide resolved
frontend/catalyst/third_party/oqc/src/CMakeLists.txt Show resolved Hide resolved
@rauletorresc rauletorresc requested a review from dime10 December 19, 2024 16:38
dime10
dime10 approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@dime10 dime10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 💪

@rauletorresc rauletorresc merged commit 11e4e4f into main Dec 19, 2024
51 of 52 checks passed
@rauletorresc rauletorresc deleted the raultorres/oqc-abi branch December 19, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dime10 dime10 dime10 approved these changes

Assignees

@rauletorresc rauletorresc

Labels
author:build-wheels Run the wheel building workflows on this Pull Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rauletorresc @dime10