Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip oqd pytests in build-wheels #1390

Merged
merged 5 commits into from
Dec 18, 2024

Conversation

paul0403
Copy link
Contributor

@paul0403 paul0403 commented Dec 18, 2024

Context:
A big redesign of oqd ion dialect and the associated toml file format took place during #1260 . Therefore, the frontend oqd pytests (which performs some toml parsing) should be removed, since (a) they are interpreting against the old toml format, and (b) the toml parsing now happens in the mlir layer alongside the actual --quantum-to-ion pass, not at the frontend python layer as a standalone.

@paul0403 paul0403 added the urgent Mark a pull request as high priority label Dec 18, 2024
@paul0403 paul0403 requested a review from a team December 18, 2024 20:44
@paul0403 paul0403 added the author:build-wheels Run the wheel building workflows on this Pull Request label Dec 18, 2024
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md on your branch with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@paul0403 paul0403 added the reviewer:require-wheels Pull Requests will need wheel building job successful before being merged label Dec 18, 2024
@dime10
Copy link
Contributor

dime10 commented Dec 18, 2024

We simply skip them instead of removing them in case they become useful in the future, e.g. if oqd wants to interact with the toml database in the frontend python layer.

I think we can remove them if they are no longer runnable. If we want to resurrect the functionality in the future the git history will still be there :)

@paul0403
Copy link
Contributor Author

We simply skip them instead of removing them in case they become useful in the future, e.g. if oqd wants to interact with the toml database in the frontend python layer.

I think we can remove them if they are no longer runnable. If we want to resurrect the functionality in the future the git history will still be there :)

I removed the entire oqd pytest suite.

Copy link
Contributor

@dime10 dime10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good 👍

Makefile Show resolved Hide resolved
@paul0403 paul0403 merged commit 99820e8 into main Dec 18, 2024
58 checks passed
@paul0403 paul0403 deleted the paul0403/2024-12-18/skip_oqd_pytest_wheels branch December 18, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author:build-wheels Run the wheel building workflows on this Pull Request reviewer:require-wheels Pull Requests will need wheel building job successful before being merged urgent Mark a pull request as high priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants