-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip oqd pytests in build-wheels #1390
Conversation
Hello. You may have forgotten to update the changelog!
|
I think we can remove them if they are no longer runnable. If we want to resurrect the functionality in the future the git history will still be there :) |
I removed the entire oqd pytest suite. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good 👍
Context:
A big redesign of oqd ion dialect and the associated toml file format took place during #1260 . Therefore, the frontend oqd pytests (which performs some toml parsing) should be removed, since (a) they are interpreting against the old toml format, and (b) the toml parsing now happens in the mlir layer alongside the actual
--quantum-to-ion
pass, not at the frontend python layer as a standalone.