Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFC] Fix doc: 'make plugin' instead of 'make standalone-plugin' #1378

Merged
merged 1 commit into from
Dec 13, 2024
Merged

[NFC] Fix doc: 'make plugin' instead of 'make standalone-plugin' #1378

merged 1 commit into from
Dec 13, 2024

Conversation

rauletorresc
Copy link
Contributor

Context: Updates related to the standalone plugin rule on the Makefile did not made it to the docs.

Description of the Change: Instruct to use make plugin instead of make standalone-plugin

@rauletorresc rauletorresc requested a review from a team December 12, 2024 22:20
@rauletorresc rauletorresc self-assigned this Dec 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md on your branch with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

dime10
dime10 approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@dime10 dime10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops thanks!

@rauletorresc rauletorresc merged commit 263224d into main Dec 13, 2024
43 checks passed
@rauletorresc rauletorresc deleted the raultorres/fix-doc-standalon-plugin branch December 13, 2024 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dime10 dime10 dime10 approved these changes

Assignees

@rauletorresc rauletorresc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rauletorresc @dime10