[frontend] Fix parameter annotation #1078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erick-xanadu
force-pushed
the
eochoa/2024-08-29/pjit-functions
branch
from
6e05b0e to
f326122
Compare
|
Hello. You may have forgotten to update the changelog!
|
dime10
approved these changes
Aug 29, 2024
dime10
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: It is not entirely clear why, but some functions return strings in their function annotations. This is not enough to perform AOT compilation, so we should not do AOT compilation in these cases.
Description of the Change: Limit AOT compilation to instances of type and jax.core.ShapedArray.
Benefits:
expm(and similar functions) can be called asqjit(expm)Possible Drawbacks: None
Related GitHub Issues: #1077