-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Track PL new stateprep error message #1057
Conversation
…ases (PennyLaneAI/pennylane#6021). We update our tests to agree with them.
Hello. You may have forgotten to update the changelog!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @paul0403 !
You're PR needs to update the PL ref to the commit (technically package version) that introduced this new behaviour no? Or is the dev build we're tracking already newer? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm guessing the kokkos failure is addressed by your other PR? Happy to overwrite the merge if so
Seems like it: Kokkos failure is because the kokkos version (dev50) is before the lightning PR where this got fixed in kokkos. The lightning PR is merged into lighting rc (PennyLaneAI/pennylane-lightning#869) and hence does not have a dev version bump. We can overwrite merge and rcrcrc should pass (or if it fails, not with the stateprep errors). Alternatively, I can open another PR in lightning and merge the kokkos changes into lightning's master, and track the bumped lightning dev version. Alternatively alternatively, we can wait for lightning to merge something into their master to trigger a dev bump, and we track that. |
Context:
PL recently changed error messages for bad stateprep/basisstate use cases (PennyLaneAI/pennylane#6021).
We update our tests to agree with them.
Benefits: Frontend tests
test_skip_initial_stateprep/TestPossibleErrors
can pass