Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track PL new stateprep error message #1057

Merged
merged 5 commits into from
Aug 27, 2024
Merged

Conversation

paul0403
Copy link
Contributor

Context:
PL recently changed error messages for bad stateprep/basisstate use cases (PennyLaneAI/pennylane#6021).
We update our tests to agree with them.

Benefits: Frontend tests test_skip_initial_stateprep/TestPossibleErrors can pass

@paul0403 paul0403 added this to the v0.8.0 milestone Aug 27, 2024
@paul0403 paul0403 requested a review from a team August 27, 2024 13:53
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/changelog.md on your branch with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link
Contributor

@rmoyard rmoyard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @paul0403 !

@dime10
Copy link
Contributor

dime10 commented Aug 27, 2024

You're PR needs to update the PL ref to the commit (technically package version) that introduced this new behaviour no? Or is the dev build we're tracking already newer?

Copy link
Contributor

@dime10 dime10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing the kokkos failure is addressed by your other PR? Happy to overwrite the merge if so

@paul0403
Copy link
Contributor Author

paul0403 commented Aug 27, 2024

I'm guessing the kokkos failure is addressed by your other PR? Happy to overwrite the merge if so

Seems like it: wires must take values lower than the number of qubits. likely came from the wire argument seeing [2,3] instead of [0,1] due to not reading the qubit manager map values.

Kokkos failure is because the kokkos version (dev50) is before the lightning PR where this got fixed in kokkos. The lightning PR is merged into lighting rc (PennyLaneAI/pennylane-lightning#869) and hence does not have a dev version bump. We can overwrite merge and rcrcrc should pass (or if it fails, not with the stateprep errors).

Alternatively, I can open another PR in lightning and merge the kokkos changes into lightning's master, and track the bumped lightning dev version.

Alternatively alternatively, we can wait for lightning to merge something into their master to trigger a dev bump, and we track that.

@dime10 dime10 merged commit 5966ccb into v0.8.0-rc Aug 27, 2024
39 of 40 checks passed
@dime10 dime10 deleted the track_PL_new_setstate_errormsg branch August 27, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants