Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename QC metrics and output QC files as TSVs #375

Merged
merged 4 commits into from
Dec 12, 2023
Merged

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Dec 12, 2023

Closes none.

Changes proposed in this pull request

  • Rename the QC metrics from camelCase to snake_case, per BIDS convention.
  • Output the QC files as TSVs instead of CSVs, per BIDS convention.

@tsalo tsalo added the breaking-change PRs that change results or interfaces. label Dec 12, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (f66ed4c) 79.02% compared to head (1dbd64f) 78.98%.

Files Patch % Lines
aslprep/cli/aggregate_qc.py 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #375      +/-   ##
==========================================
- Coverage   79.02%   78.98%   -0.05%     
==========================================
  Files          39       39              
  Lines        4157     4149       -8     
  Branches      602      602              
==========================================
- Hits         3285     3277       -8     
  Misses        676      676              
  Partials      196      196              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsalo tsalo merged commit d6c868c into PennLINC:main Dec 12, 2023
25 checks passed
@tsalo tsalo deleted the qc-names branch December 12, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change PRs that change results or interfaces.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants