Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise error if no M0 volume(s)/estimate available and background suppression is enabled #337

Merged
merged 2 commits into from
Nov 7, 2023

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Nov 7, 2023

Closes #335.

Changes proposed in this pull request

  • When M0Type is "Absent" and CBF volumes are not already available, check if background suppression is enabled. If it is, then raise a ValueError, as the control volumes cannot be used for calibration when background suppression is enabled.

@tsalo tsalo added the bug Something isn't working label Nov 7, 2023
@tsalo tsalo self-assigned this Nov 7, 2023
@tsalo tsalo merged commit 8e2e73d into PennLINC:main Nov 7, 2023
20 checks passed
@tsalo tsalo deleted the control-bs branch November 7, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should we prevent no-M0 processing when background suppression is enabled
1 participant