Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shift PostLabelingDelay(s) by slice times #280

Merged
merged 31 commits into from
May 17, 2023
Merged

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented May 9, 2023

Closes #189.

Changes proposed in this pull request

  • Shift PLDs by slice times, when necessary.

@tsalo tsalo added the enhancement New feature or request label May 9, 2023
@tsalo
Copy link
Member Author

tsalo commented May 9, 2023

scrub_summary is failing for the Philips dataset (which is the only single-PLD test dataset with slice timing info).

@codecov-commenter
Copy link

codecov-commenter commented May 12, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@38962f2). Click here to learn what that means.
Patch coverage: 90.29% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #280   +/-   ##
=======================================
  Coverage        ?   49.52%           
=======================================
  Files           ?      132           
  Lines           ?    12215           
  Branches        ?        0           
=======================================
  Hits            ?     6050           
  Misses          ?     6165           
  Partials        ?        0           
Impacted Files Coverage Δ
aslprep/tests/utils.py 43.75% <14.28%> (ø)
aslprep/workflows/asl/cbf.py 81.36% <80.00%> (ø)
aslprep/interfaces/cbf_computation.py 81.98% <83.87%> (ø)
aslprep/tests/test_interfaces_cbf_computation.py 100.00% <100.00%> (ø)
aslprep/utils/misc.py 62.50% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tsalo tsalo merged commit 9dd615f into PennLINC:main May 17, 2023
@tsalo tsalo deleted the shift-plds branch May 17, 2023 16:29
@tsalo tsalo self-assigned this May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PLD/TI not adjusted by slice timing for 2D datasets?
2 participants