Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "mean" from mean CBF filenames and add "timeseries" to 4D CBF filenames #257

Merged
merged 5 commits into from
Apr 7, 2023

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Apr 7, 2023

Closes none, but references #232.

Changes proposed in this pull request

  • Rename desc-mean_cbf.nii.gz output to cbf.nii.gz, as this is the primary output for analysis.
  • Rename cbf.nii.gz output to desc-timeseries_cbf.nii.gz.
  • Rename desc-meanScore_cbf.nii.gz output to desc-score_cbf.nii.gz.
  • Rename desc-score_cbf.nii.gz to desc-scoreTimeseries_cbf.nii.gz.
  • Rename desc-bat_cbf.nii.gz to att.nii.gz (arterial transit time).
  • Add Unit metadata to appropriate files, along with source-file info.

@tsalo tsalo added the breaking-change PRs that change results or interfaces. label Apr 7, 2023
@tsalo tsalo changed the title Make mean CBF images the primary outputs Remove "mean" from mean CBF filenames and add "timeseries" to 4D CBF filenames Apr 7, 2023
@tsalo tsalo merged commit 93565ae into PennLINC:main Apr 7, 2023
@tsalo tsalo deleted the update-outputs branch April 7, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change PRs that change results or interfaces.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant