Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallelize parcellation and replace atlases #254

Merged
merged 37 commits into from
Apr 6, 2023

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Apr 5, 2023

Closes #247.

Changes proposed in this pull request

  • Replace atlases with ones from XCP-D. We'll need to replace these with the AtlasPack ones once those are finalized and released.
  • Dramatically simplify the output workflow. Only use one for both GE and non-GE data.
  • Fix bug with generating standard-space derivatives. The problem was that density was not defined as an entity in the config file, so it was being interpreted as a metadata field with a value of _undefined.
  • Use MapNodes for managing parcellation and writing parcellated derivatives.
  • Apply series of transforms from MNI152NLin6Asym to ASL reference space to atlases.
  • Replace uses of ANTS's ApplyTransforms with a modified version of FixHeaderApplyTransforms.
  • Rename init_cbfroiquant_wf to init_parcellate_cbf_wf.

@tsalo tsalo added the refactor Changes to the codebase that don't impact workflow inputs or outputs. label Apr 5, 2023
@tsalo tsalo changed the title Parallelize parcellation Parallelize parcellation and replace atlases Apr 5, 2023
@tsalo tsalo added the breaking-change PRs that change results or interfaces. label Apr 5, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.17 ⚠️

Comparison is base (2151899) 50.94% compared to head (b85cae0) 50.78%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #254      +/-   ##
==========================================
- Coverage   50.94%   50.78%   -0.17%     
==========================================
  Files         132      135       +3     
  Lines       12595    12595              
==========================================
- Hits         6417     6396      -21     
- Misses       6178     6199      +21     
Impacted Files Coverage Δ
aslprep/interfaces/ants.py 100.00% <ø> (ø)
aslprep/interfaces/cbf_computation.py 82.53% <ø> (-1.03%) ⬇️
aslprep/interfaces/parcellation.py 97.43% <ø> (ø)
aslprep/tests/test_cli.py 100.00% <ø> (ø)
aslprep/utils/atlas.py 7.89% <ø> (ø)
aslprep/utils/misc.py 64.21% <ø> (-3.06%) ⬇️
aslprep/workflows/asl/base.py 81.53% <ø> (ø)
aslprep/workflows/asl/cbf.py 80.55% <ø> (-2.88%) ⬇️
aslprep/workflows/asl/confounds.py 100.00% <ø> (ø)
aslprep/workflows/asl/ge_utils.py 83.33% <ø> (-0.15%) ⬇️
... and 6 more

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tsalo tsalo marked this pull request as ready for review April 6, 2023 22:07
@tsalo tsalo merged commit cf94815 into PennLINC:main Apr 6, 2023
@tsalo tsalo deleted the parallelize-parcellation branch April 6, 2023 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change PRs that change results or interfaces. refactor Changes to the codebase that don't impact workflow inputs or outputs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parallelize across atlases and resolutions
2 participants