Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use LabelingEfficiency as BASIL --alpha parameter #233

Merged
merged 3 commits into from
Mar 13, 2023

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Mar 13, 2023

Closes #229.

Changes proposed in this pull request

  • Feed LabelingEfficiency metadata field, when defined, as the --alpha parameter for BASIL (oxford_asl).

@tsalo tsalo added the enhancement New feature or request label Mar 13, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (4a2f920) 44.06% compared to head (876144a) 44.07%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #233   +/-   ##
=======================================
  Coverage   44.06%   44.07%           
=======================================
  Files         130      130           
  Lines       12358    12360    +2     
=======================================
+ Hits         5446     5448    +2     
  Misses       6912     6912           
Impacted Files Coverage Δ
aslprep/interfaces/cbf_computation.py 71.95% <100.00%> (+0.05%) ⬆️
aslprep/workflows/asl/cbf.py 59.59% <100.00%> (+0.16%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tsalo tsalo merged commit 0e3b45a into PennLINC:main Mar 13, 2023
@tsalo tsalo deleted the basil-param branch March 13, 2023 15:59
@tsalo tsalo added bug Something isn't working and removed enhancement New feature or request labels Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The labelingefficiency in .json was not used when calculating basilcbf
2 participants