Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remotedialer: segfaults in sync.Pool when calling ClientConnect() #6

Closed
wants to merge 1 commit into from

Conversation

zhucebuliaolongchuan
Copy link
Contributor

@zhucebuliaolongchuan zhucebuliaolongchuan commented Nov 18, 2020

Issue: PELEDGE19-3771 - edge-proxy has encountered segmentation fault during runtime due to third party package logrus used in remotedialer. Similar issue could be found here: golang/go#24640. While the issue happens within golang runtime and the problem has been unresolved even for the latest go release.

Potential solution: updating module logrus to v1.7.0 as it introduces a customized buffer pool API instead of using sync pool from native go lib. Details for the v1.7.0 release could be found here

Changes:

  • Update go modules
  • Change org name to new org name: armPelionEdge -> PelionIoT
  • Fix Dockerfile build error

@c1728p9
Copy link

c1728p9 commented Nov 19, 2020

If you want to update just logrus you can use the following commands:

$ go get github.com/sirupsen/logrus@v1.7.0
$ go mod vendor

@zhucebuliaolongchuan
Copy link
Contributor Author

$ go get github.com/sirupsen/logrus@v1.7.0
$ go mod vendor

I just did this in #9

@zhucebuliaolongchuan
Copy link
Contributor Author

Close this PR, since this PR has been separated to three PRs so we could merge the change in a safer way - #7 #8 #9 .

@zhucebuliaolongchuan zhucebuliaolongchuan deleted the update-dependencies branch November 19, 2020 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants