Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take a URL from config value to fetch institution list for Registry #649

Merged
merged 4 commits into from
Jan 22, 2024
Merged

Take a URL from config value to fetch institution list for Registry #649

merged 4 commits into from
Jan 22, 2024

Conversation

haoming29
Copy link
Contributor

Fixes #635 and Closes #648

To test locally, you may use the topology URL which gives valid institution list for OSDF: https://topology.opensciencegrid.org/institution_ids

@haoming29 haoming29 added the enhancement New feature or request label Jan 12, 2024
@haoming29 haoming29 added this to the v7.5.0 milestone Jan 12, 2024
@haoming29 haoming29 mentioned this pull request Jan 12, 2024
Closed
jhiemstrawisc
jhiemstrawisc approved these changes Jan 19, 2024
View reviewed changes
Copy link
Member

@jhiemstrawisc jhiemstrawisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's one typo that should be cleaned up, and two small comments that you can choose to ignore if you want. Otherwise LGTM. Once the typo is fixed, I'll approve and merge.

docs/parameters.yaml Outdated Show resolved Hide resolved
registry/registry_ui_test.go Show resolved Hide resolved
registry/registry_ui.go Outdated Show resolved Hide resolved
@haoming29 haoming29 merged commit cb64873 into PelicanPlatform:main Jan 22, 2024
9 checks passed
@haoming29 haoming29 deleted the registry-api-p4 branch January 22, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhiemstrawisc jhiemstrawisc jhiemstrawisc approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v7.5.0
2 participants
@haoming29 @jhiemstrawisc