Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

End-to-end test for object get/put with xrootd #645

Merged
merged 10 commits into from
Jan 24, 2024
Merged

End-to-end test for object get/put with xrootd #645

merged 10 commits into from
Jan 24, 2024

Conversation

joereuss12
Copy link
Contributor

@joereuss12 joereuss12 commented Jan 11, 2024 •
edited
Loading

Changes include:

  • Made disabiling progress bars a configurable option, helps with testing because the GET that runs after the PUT tries to use the closed mpb instance of the PUT which it does not like.
  • Wrote test for object get/put spinning up the federation in a box, running the command, and checking the debug output for success.

@joereuss12 joereuss12 added this to the v7.5.0 milestone Jan 11, 2024
@joereuss12 joereuss12 linked an issue Jan 12, 2024 that may be closed by this pull request
End-to-end test for pelican object put and pelican object get #582
Closed
@joereuss12
Copy link
Contributor Author

joereuss12 commented Jan 12, 2024 •
edited
Loading

Ready for review: made some changes and added a bash script to run this end-to-end test that can hopefully act as a template for future client command tests.

@joereuss12 joereuss12 requested a review from haoming29 January 16, 2024 17:25
@joereuss12 joereuss12 force-pushed the end-to-end-put-and-get-branch branch 7 times, most recently from da5b80a to b7fd313 Compare January 17, 2024 17:42
jhiemstrawisc
jhiemstrawisc requested changes Jan 19, 2024
View reviewed changes
.github/workflows/test.yml Show resolved Hide resolved
cmd/object_get_put_test.go Outdated Show resolved Hide resolved
cmd/object_get_put_test.go Outdated Show resolved Hide resolved
cmd/object_get_put_test.go Outdated Show resolved Hide resolved
cmd/object_get_put_test.go Show resolved Hide resolved
docs/parameters.yaml Outdated Show resolved Hide resolved
github_scripts/get_put_test.sh Outdated Show resolved Hide resolved
github_scripts/get_put_test.sh Show resolved Hide resolved
@joereuss12
End-to-end test for object get/put with xrootd
06e1fe6 
Changes include:
- Fix in `main_test.go` to revert the version back to what it was
  before.
- Made disabiling progress bars a configurable option, helps with
  testing because the GET that runs after the PUT tries to use the
  closed mpb instance of the PUT which it does not like.
- Wrote test for object get/put spinning up the federation in a box,
  running the command, and checking the debug output for success.
@joereuss12
Improved e2e test for pelican object get/put
24914e9 
This commit changes:
- Remove redundant cancel/fedcancel in cmd/object_get_put_test.go
- Added a shell script to run e2e test for object get/put
- Added that script to the test workflow
@joereuss12
changed permissions of file
f6dca80
@joereuss12
Test gives goreleaser proper tag for testing
ac77381
@joereuss12
Addressed review comments
651cf34
@joereuss12
Fix linter issues
39ab716
@joereuss12
Do not change user & hardcode sleep
686f732 
Changes now do not rely on making another user. In addition, introduced
a loop that sleeps .5 seconds, then checks if servers are running (for
max 10 seconds) instead of just sleeping for 10
@joereuss12
Added test to workflow
861bb5f
@joereuss12
Make common name config dir more unique
6353fff
@joereuss12
Change curl request to GET /health instead
ade668e 
Curling /server required authentication that github did not like, this
should fix that
@joereuss12 joereuss12 force-pushed the end-to-end-put-and-get-branch branch from 5b1187c to ade668e Compare January 24, 2024 22:26
@jhiemstrawisc
Copy link
Member

LGTM. Another crucial piece of the overall puzzle -- our first E2E integration test!

@jhiemstrawisc jhiemstrawisc merged commit c35e446 into PelicanPlatform:main Jan 24, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhiemstrawisc jhiemstrawisc jhiemstrawisc approved these changes

@haoming29 haoming29 Awaiting requested review from haoming29

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v7.5.0
Development

Successfully merging this pull request may close these issues.

End-to-end test for pelican object put and pelican object get
3 participants
@joereuss12 @jhiemstrawisc @haoming29