Various script tweaks #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
matyasselmeci
commented
Dec 28, 2024
matyasselmeci
commented
- Do all our work in a temp dir instead of the current working directory
- Don't detect ppc64el if it's not supported anywhere anyway
- Print message about Windows to stderr so the user can see it
- Only print the "Installing ..." message for MacOS if we're on a supported arch
…stdout is captured)
Instead of creating and deleting files in the current directory, do everything in a temporary directory which we clean up afterwards.
This reverts commit 8ae7108. Looks like we have debs for ppc64el
CannonLock
approved these changes
Dec 30, 2024
There was a problem hiding this comment.
@matyasselmeci Wow thanks for the effort! Looks good and passes the tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.