This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Updating docker tests to make it easier to follow & ensure it listens on the right interface on docker #1851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o reflect the same
joshuafernandes
changed the title
joshuafernandes
commented
Aug 14, 2019
| bash tests/dgoss dockerfile $DOCKER_FILE \ | ||
| > ./reports/00.xml || i=`expr $i + 1` | ||
| # fail fast if we dont pass static checks | ||
| if [[ $i != 0 ]]; then exit $i; fi |
There was a problem hiding this comment.
checks for the dockerfile too
joshuafernandes
commented
Aug 14, 2019
| # Test for normal startup with ports opened | ||
| GOSS_FILES_PATH=tests/01 \ | ||
| bash tests/dgoss \ | ||
| run $DOCKER_IMAGE \ | ||
| --network=dev \ | ||
| --p2p-host=0.0.0.0 \ | ||
| --rpc-http-enabled \ | ||
| --rpc-http-host=0.0.0.0 \ |
There was a problem hiding this comment.
Removing duplicity since these are specified in the docker image
joshuafernandes
commented
Aug 14, 2019
| tcp:8545: | ||
| listening: true | ||
| tcp:8546: | ||
| listening: true |
There was a problem hiding this comment.
Removing duplicate test fie - see goss_wait.yaml
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Fixed Issue(s)