This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
[PAN-2825] eea send raw transaction with privacy group id #1611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iikirilov
force-pushed
the
feature/eea_sendRawTransaction_with_privacyGroupId
branch
from
85900f1 to
99d3f2d
Compare
ekellstrand
reviewed
Jun 27, 2019
...core/src/test/java/tech/pegasys/pantheon/ethereum/privacy/PrivateTransactionHandlerTest.java
Outdated
Show resolved
Hide resolved
ekellstrand
reviewed
Jun 27, 2019
| @@ -50,6 +50,14 @@ | |||
| + "6e766966746a69697a706a52742b4854754642733d8a726573747269637465" | |||
| + "64"; | |||
|
|
|||
| private static final String VALID_PRIVATE_TRANSACTION_RLP_PRIVACY_GROUP = | |||
There was a problem hiding this comment.
Can this be generated so that it is clear how this is built?
There was a problem hiding this comment.
No - because I am testing here that the generation will produce these fixed values. If I generate these values and test if the generator produces the generated values (which it obviously will) I am not really testing anything. If someone messes with the generator then we will not catch the error :)
ekellstrand
reviewed
Jun 27, 2019
...a/tech/pegasys/pantheon/ethereum/jsonrpc/internal/methods/privacy/EeaDeletePrivacyGroup.java
Outdated
Show resolved
Hide resolved
iikirilov
force-pushed
the
feature/eea_sendRawTransaction_with_privacyGroupId
branch
9 times, most recently
from
a9444dc to
9007712
Compare
iikirilov
force-pushed
the
feature/eea_sendRawTransaction_with_privacyGroupId
branch
from
9007712 to
f8f8d00
Compare
* extract privacy group id from private transaction if present * extract privateFor/privateFrom if privacy group id is not present
iikirilov
force-pushed
the
feature/eea_sendRawTransaction_with_privacyGroupId
branch
from
f8f8d00 to
2782fb7
Compare
iikirilov
deleted the
feature/eea_sendRawTransaction_with_privacyGroupId
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Allows to send private transaction with privacy group id instead of privateFor/privateFrom
Fixed Issue(s)
PAN-2825