Fixes for recent PHP versions #419
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReflectionNamedType::__toString() was deprecated in PHP 7.1.0 in favor of ReflectionNamedType::getName() and the deprecation warning will break the JSON output
parsing files including broken require_once (e.g. path can not be resolved) will trigger an error which is handled by onError converting it to an ErrorException and throwing it again. This *should* then be caught by onException to convert and print this as JSON and exit. But due to https://bugs.php.net/bug.php?id=66216 this does not happen and the parser exits an empty output which results in another Exception in php-proxy.coffee trying to parse the empty string as JSON.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some issues with recent versions of PHP:
\Errors soErrorHandler::onExceptionneeds to accept\Throwables too, see ErrorHandler: Renaming \Exception to \Throwable because PHP 7 throws Errors to #402 / thx @vcampitelliReflectionNamedType::__toString()was deprecated in PHP 7.1.0 in favor ofReflectionNamedType::getName()resolves #402 (by including it)
resolves #417
fixes #412
fixes #415