Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pair distribution function #320

Merged
merged 29 commits into from
Jun 4, 2024

Conversation

ThoChat
Copy link
Collaborator

@ThoChat ThoChat commented Mar 28, 2024

to solve issue #325

Copy link
Collaborator

@chraibi chraibi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you also need to use the formating script before you commit/push

pedpy/_version.py Outdated Show resolved Hide resolved
pedpy/methods/other_characterisation_methods.py Outdated Show resolved Hide resolved
pedpy/methods/pair_distribution_function_calculator.py Outdated Show resolved Hide resolved
@chraibi
Copy link
Collaborator

chraibi commented Mar 29, 2024

In general, I'm confused compute_pair_distibution_function being in two different files.

pedpy/_version.py Outdated Show resolved Hide resolved
@chraibi chraibi added the new feature New feature or request label Apr 4, 2024
@chraibi chraibi self-requested a review May 28, 2024 13:14
@chraibi chraibi marked this pull request as ready for review May 28, 2024 13:14
@chraibi chraibi self-requested a review May 28, 2024 13:42
chraibi
chraibi previously approved these changes May 28, 2024
Copy link
Collaborator

@schroedtert schroedtert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new functions are not shown in the API guide on the website

@chraibi chraibi dismissed schroedtert’s stale review June 4, 2024 08:14

Was done by the latest commit.

@chraibi chraibi merged commit ef4df98 into PedestrianDynamics:main Jun 4, 2024
20 checks passed
chraibi added a commit to chraibi/PedPy that referenced this pull request Jun 4, 2024
* udate-version-file

* First implementation pdf computation

* First debuged version

* 2d and optimisation

* Add notebook to test pdf function

* Add documentation and vectorised version of dist calculation

* fix stack of arrays and use Divide

* Raise warning for division by null values during pdf computation PedestrianDynamics#330

* Add a parameter to pdf to control the number of data scrambling loops PedestrianDynamics#326

* Method error fix

* Change atribute name and documentation

* First modification of the User guide

* Final Changes User guide and remove test codes

* Minor correction User guide

* del _version for the PR

* Clear  User Guide output

* Bug fix

* Changing name of the file containning the pdf computation

* Minor correction and formating to pass all continuity tests

* Editing the text of PDF

* fix small typos

* Changing name in the API doc

---------

Co-authored-by: Mohcine Chraibi <m.chraibi@fz-juelich.de>
@ThoChat ThoChat deleted the Pair-Distribution-Function branch September 12, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants