Add Gauss speed profile #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chraibi
added
new feature
schroedtert
requested changes
Mar 20, 2024
schroedtert
requested changes
Mar 22, 2024
There was a problem hiding this comment.
Content wise it looks great to me, but there are still some formatting errors:
Could you have a look at this? When you add the latest commit from main the CI would pick this up. Otherwise you can run the scripts/ci.sh locally. It should hopefully also report these. Otherwise let me know, then I need to take a more detailed look at this.
schroedtert
requested changes
Apr 2, 2024
schroedtert
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #304. It introduces the possibility to calculate speed profiles with Gauss method similar to density profiles.
This would make analysis relying on Gauss method consistent.