fix(webcomponents): fix downloading wrong DER format (#146)

PeculiarVentures · Jun 27, 2024 · 9073275 · 9073275
1 parent e304b1d
commit 9073275
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 12 deletions.
diff --git a/packages/webcomponents/src/crypto/pkcs10_certificate_request.ts b/packages/webcomponents/src/crypto/pkcs10_certificate_request.ts
@@ -162,7 +162,7 @@ export class Pkcs10CertificateRequest extends AsnData<CertificationRequest> {
 
   public downloadAsDER(name?: string) {
     Download.csr.asDER(
-      this.toString('hex'),
+      this.raw,
       name || this.commonName,
     );
   }

diff --git a/packages/webcomponents/src/crypto/x509_attribute_certificate.ts b/packages/webcomponents/src/crypto/x509_attribute_certificate.ts
@@ -146,7 +146,7 @@ export class X509AttributeCertificate extends AsnData<AttributeCertificate> {
 
   public downloadAsDER(name?: string) {
     Download.attrCert.asDER(
-      this.toString('hex'),
+      this.raw,
       name || this.commonName,
     );
   }

diff --git a/packages/webcomponents/src/crypto/x509_certificate.ts b/packages/webcomponents/src/crypto/x509_certificate.ts
@@ -258,7 +258,7 @@ export class X509Certificate extends AsnData<Certificate> {
 
   public downloadAsDER(name?: string) {
     Download.cert.asDER(
-      this.toString('hex'),
+      this.raw,
       name || this.commonName,
     );
   }

diff --git a/packages/webcomponents/src/crypto/x509_crl.ts b/packages/webcomponents/src/crypto/x509_crl.ts
@@ -138,7 +138,7 @@ export class X509Crl extends AsnData<CertificateList> {
 
   public downloadAsDER(name?: string) {
     Download.crl.asDER(
-      this.toString('hex'),
+      this.raw,
       name || this.commonName,
     );
   }

diff --git a/packages/webcomponents/src/utils/download.ts b/packages/webcomponents/src/utils/download.ts
@@ -21,9 +21,9 @@ export class Download {
       );
     },
 
-    asDER: (hex: string, name: string) => {
+    asDER: (raw: ArrayBuffer, name: string) => {
       downloadFromBuffer(
-        Convert.FromString(hex),
+        raw,
         name,
         'cer',
         'application/pkix-cert',
@@ -41,9 +41,9 @@ export class Download {
       );
     },
 
-    asDER: (hex: string, name: string) => {
+    asDER: (raw: ArrayBuffer, name: string) => {
       downloadFromBuffer(
-        Convert.FromString(hex),
+        raw,
         name,
         'cer',
         'application/pkix-attr-cert',
@@ -61,9 +61,9 @@ export class Download {
       );
     },
 
-    asDER: (hex: string, name: string) => {
+    asDER: (raw: ArrayBuffer, name: string) => {
       downloadFromBuffer(
-        Convert.FromString(hex),
+        raw,
         name,
         'csr',
         'application/pkcs10',
@@ -81,9 +81,9 @@ export class Download {
       );
     },
 
-    asDER: (hex: string, name: string) => {
+    asDER: (raw: ArrayBuffer, name: string) => {
       downloadFromBuffer(
-        Convert.FromString(hex),
+        raw,
         name,
         'crl',
         'application/pkix-crl',